set a net.Conn with the correct addresses on the tls.ClientHelloInfo #4001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
force-pushed
the
getclienthelloinfo-conn
branch
from
36ff0f4
to
41214e0
Compare
marten-seemann
force-pushed
the
getclienthelloinfo-conn
branch
from
41214e0
to
d5a4a70
Compare
marten-seemann
commented
Jul 29, 2023
| @@ -140,6 +140,30 @@ var _ = Describe("Handshake tests", func() { | |||
| Expect(err).ToNot(HaveOccurred()) | |||
| }) | |||
|
|
|||
| It("has the right local and remote address on the ClientHelloInfo.Conn", func() { | |||
There was a problem hiding this comment.
Now including an end-to-end test to make sure this API never accidentally breaks again.
Codecov Report
@@ Coverage Diff @@
## master #4001 +/- ##
==========================================
- Coverage 82.86% 82.76% -0.10%
==========================================
Files 146 147 +1
Lines 14729 14744 +15
==========================================
- Hits 12204 12202 -2
- Misses 2025 2040 +15
- Partials 500 502 +2
|
mholt
approved these changes
Jul 31, 2023
There was a problem hiding this comment.
Sorry it took me over the weekend. At a glance this looks good! If we can get the remote/local addr at time of handshake, that's good enough for our use case for now, I think.
Thank you :)
I can probably get this out in Caddy 2.7. When are you planning the next release?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4000.
@mholt, would you mind taking a look at this PR?