Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check transport parameters after 0-RTT resumption #3985

Merged

Conversation

tanghaowillow
Copy link
Contributor

Closes #3978

@marten-seemann marten-seemann added this to the v0.38 milestone Jul 21, 2023
@tanghaowillow tanghaowillow force-pushed the check-new-transport-parameters branch from 603737f to 752e89b Compare July 22, 2023 11:05
internal/wire/transport_parameters.go Outdated Show resolved Hide resolved
internal/wire/transport_parameters.go Outdated Show resolved Hide resolved
internal/wire/transport_parameters.go Outdated Show resolved Hide resolved
@marten-seemann
Copy link
Member

Looks good to me, thank you @tanghaowillow! We'll merge this PR once v0.37.1 is out.

@marten-seemann marten-seemann changed the title check new transport parameters on the client side check transport parameters after 0-RTT resumption Aug 1, 2023
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #3985 (5008917) into master (f3a0ce1) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3985      +/-   ##
==========================================
+ Coverage   82.76%   82.82%   +0.06%     
==========================================
  Files         147      147              
  Lines       14744    14758      +14     
==========================================
+ Hits        12202    12223      +21     
+ Misses       2041     2034       -7     
  Partials      501      501              
Files Changed Coverage Δ
connection.go 72.74% <100.00%> (+0.52%) ⬆️
internal/wire/transport_parameters.go 89.27% <100.00%> (+0.25%) ⬆️

@marten-seemann marten-seemann merged commit 1c47ebe into quic-go:master Aug 2, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

check that the server didn't reduce flow control transport parameters
2 participants