-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix(sql): fix rewrite sample by
to group by
same column names' bug.
#5113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sample by
to group by
same columns bug fix.sample by
to group by
same column names bug fix.
sample by
to group by
same column names bug fix.sample by
to group by
same column names bug.
sample by
to group by
same column names bug.sample by
to group by
same column names' bug.
sample by
to group by
same column names' bug.sample by
to group by
same column names' bug.
Hey @kafka1991 , do you have bandwidth to get this up to date with master? If not, I can pick this up this week. Sorry for the delays gettin this wrapped up! Also, here is a test case: select dateadd('d', 1, timestamp) "timestamp" , symbol from trades
sample by 10m |
b32305c
to
132b9fe
Compare
@nwoolmer Have already rebase master onto current branch. Please continue to take a review.
This test can also be passed in the current branch. |
another issue in the same area, the following SQL fails with obscure error: SELECT timestamp+60000000 as 'timestamp', timestamp, 0 AS "extra_column"
FROM sample_table
WHERE name = 'XYZ'
SAMPLE BY (1m); |
This issue and #5164 are both in the same area and have been fixed in the PR. |
epic, thank you! |
Fixes #5105
Fixes #5164