Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(create): update standard lint dependencies, fix #12872 #12939

Closed
wants to merge 1 commit into from

Conversation

IlCallo
Copy link
Member

@IlCallo IlCallo commented Mar 25, 2022

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Documentation
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch (or v[X] branch)
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on a Electron app
  • Any necessary documentation has been added or updated in the docs or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to start a new feature discussion first and wait for approval before working on it)

Other information:
Reference: quasarframework/quasar-starter-kit#167
Changes to quasar-v2/ts-webpack/BASE/quasar.config.js remove some TS linting errors

@rstoenescu
Copy link
Member

This clashed with Yusuf's PR, so recreated it (was easier) and pushed it then released it.
Nice finding for the node eslint plugin!

@rstoenescu rstoenescu closed this Mar 27, 2022
@IlCallo IlCallo deleted the fix-create-deps branch March 28, 2022 10:47
@IlCallo
Copy link
Member Author

IlCallo commented Mar 28, 2022

@rstoenescu no problem, but please integrate these changes too (or any comment inside those empty functions, or comment the whole empty functions altogether), or people creating a webpack + TS + ESLint will have linting errors OOB

image

@rstoenescu
Copy link
Member

@IlCallo can you push a commit for this with the original lines commented out pls? Also, bump the version of create-quasar.

@IlCallo
Copy link
Member Author

IlCallo commented Mar 29, 2022

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants