-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix OpenTelemetry Metrics and Logs endpoint resolution #46354
Conversation
Fixes quarkusio#46351
/cc @brunobat (opentelemetry), @radcortez (opentelemetry) |
...ntime/src/main/java/io/quarkus/opentelemetry/runtime/exporter/otlp/OTelExporterRecorder.java
Show resolved
Hide resolved
...ntime/src/main/java/io/quarkus/opentelemetry/runtime/exporter/otlp/OTelExporterRecorder.java
Show resolved
Hide resolved
Let me have a look |
Looks like I implemented the metrics endpoint resolver, created unit tests for it and forgot to actually use it.🙄 |
Status for workflow
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manually tested.
Tried Wiremock but got nowhere as the payloads are protobuf and Wiremock doesn't seem to detect the calls.
The IT test setup is complex with test containers but will give it a try in the future. I think we can merge this for now.
Fixes #46351
@brunobat I'm not entirely sure if we can easily add tests for it?