Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OpenTelemetry Metrics and Logs endpoint resolution #46354

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Feb 19, 2025

Fixes #46351

@brunobat I'm not entirely sure if we can easily add tests for it?

@gsmet gsmet requested a review from brunobat February 19, 2025 10:14
Copy link

quarkus-bot bot commented Feb 19, 2025

/cc @brunobat (opentelemetry), @radcortez (opentelemetry)

@brunobat
Copy link
Contributor

Let me have a look

@brunobat brunobat marked this pull request as ready for review February 19, 2025 10:27
@brunobat
Copy link
Contributor

Looks like I implemented the metrics endpoint resolver, created unit tests for it and forgot to actually use it.🙄
The Logs one is just a copy/paste error.
Manually testing this for now.

Copy link

quarkus-bot bot commented Feb 19, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 19f2ec6.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ Native Tests - HTTP

📦 integration-tests/rest-client-reactive

io.quarkus.it.rest.client.BasicTestIT.shouldCreateClientSpans - History

  • expected: <1> but was: <2> - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: expected: <1> but was: <2>
	at io.quarkus.it.rest.client.BasicTest.shouldCreateClientSpans(BasicTest.java:216)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestMethod(QuarkusTestExtension.java:799)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

Copy link
Contributor

@brunobat brunobat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually tested.
Tried Wiremock but got nowhere as the payloads are protobuf and Wiremock doesn't seem to detect the calls.
The IT test setup is complex with test containers but will give it a try in the future. I think we can merge this for now.

@geoand geoand merged commit 4ec24b1 into quarkusio:main Feb 19, 2025
47 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.21 - main milestone Feb 19, 2025
@gsmet gsmet modified the milestones: 3.21 - main, 3.19.1 Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Otel logging does not respond to it's config property.
3 participants