-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SmallRye Config to 3.12.0 #46249
Conversation
@@ -193,7 +193,8 @@ private static void registerImplicitConverter( | |||
|
|||
public static Object newInstance(Class<?> configClass) { | |||
if (configClass.isAnnotationPresent(ConfigMapping.class)) { | |||
return ReflectUtil.newInstance(ConfigMappingLoader.getImplementationClass(configClass)); | |||
// TODO - radcortez - mapping classes cannot be initialized like this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I understand this comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is what causes #39431. There is no exception, since the object is created, but all the values are not populated since it didn't call the correct constructor.
I added the TODO there to fix that later... the code has been like this for some time without much incident, but I need to fix it.
fd6e63c
to
88c46b4
Compare
🎊 PR Preview f3068af has been successfully built and deployed to https://quarkus-pr-main-46249-preview.surge.sh/version/main/guides/
|
Status for workflow
|
@gsmet is it possible to get this in any sooner than 3.21 |
@mikethecalamity could you clarify why you would want this earlier? Just to be sure I didn’t miss something. The current plan is to push it in 3.19. |
@gsmet I just wanted the fix for smallrye/smallrye-config#1305 But 3.19 would be perfect. I just saw it was only tagged to 3.21 currently and didn't want to wait 2 months. |
@gsmet I guess this didn't make it into 3.19? The quarkus-bom that just dropped looks like it still has 3.11.2 |
Unfortunately, we found a possible issue with this update (which we are still investigating), and it was risky to do the backport. I've prepared a Alternatively, you can overrride the SR Config version in Quarkus |
3.19 is not officially released yet. My plan is to include SR Config 3.11.3 in 3.19.1 next week and make 3.19.1 the first official release. |
Quarkus:
This PR also makes some improvements in the startup time and RSS by:
MethodHandle
used to construct the mappings (and all inner elements). In the native image, becauseClassValue
is substituted byConcurrentHashMap
, it is considerably slower due to the locking mechanism. Check the full explanation here:STATIC_INIT
phase. Until now, mappings shared betweenSTATIC_INIT
andRUNTIME
would be initialized twice.%profile.*
if the source does not contain profile property names.Used
config-quickstart
to measure improvements with Java 21 Temurin and Graal 21: