Cleanup Hibernate ORM bytecode enhancer #46226
Merged
+11
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @gsmet (hibernate-orm) |
Sanne
added
the
area/housekeeping
yrodiere
reviewed
Feb 12, 2025
...rm/deployment/src/main/java/io/quarkus/hibernate/orm/deployment/HibernateEntityEnhancer.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
Sanne
force-pushed
the
EnhancementCleanup
branch
from
ed42bb2 to
081f94e
Compare
Sanne
force-pushed
the
EnhancementCleanup
branch
from
081f94e to
d755488
Compare
Status for workflow
|
yrodiere
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had some pending cleanups here; the threadlocal workaround is not longer necessary, and experience from the Hibernate ORM side led us to fine-tune the list of constants passed into
CoreTypePool.