Enforce the platform constraints when resolving the Quarkus bootstrap Gradle resolver dependencies #44503
+49
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/devtools
|
This is a quick fix. I think @cdsap would do it differently though. Here is a branch where I tried to re-work it https://github.com/quarkusio/quarkus/compare/main...aloubyansky:quarkusDev-dependency-warn-config-cache?expand=1 but I'm still missing something, it fails to resolve the platform config. |
This comment has been minimized.
This comment has been minimized.
… Gradle resolver dependencies
aloubyansky
force-pushed
the
quarkusDev-dependency-warn
branch
from
8873bf0 to
94140f2
Compare
Status for workflow
|
|
@aloubyansky do you want us to merge this one for 3.17? |
|
Yeah, i think it's worth it. |
gsmet
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #43608