Improve @SecureField detection lookup exclusions #40822
Merged
+13
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalvavrik
changed the title
Status for workflow
|
Great idea! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When analyzing #40780 I mentioned the algorithm used for detection of
@SecureFieldis also looking into types that are excluded from lookup in other places of the same algorithm. My thinking is that if someone has a field of one of excluded type (e.g. type fromjava.package) inside DTO, it is possible that custom subclass could have a field annotated with@SecureField. Nevertheless it is trying to detect IMO very unlikely situation and for now it's better to shorten detection time. Users are advised to tests every secure field they annotate by Quarkus docs.I'll try to provide better detection with refactoring of this algorithm based on a new Jandex version in the future. That won't be backportable. This PR is.