Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map OIDC scope attribute to the SecurityIdentity permissions #35923

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Map OIDC scope attribute to the SecurityIdentity permissions #35923

merged 1 commit into from
Sep 15, 2023
+197 −7

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Sep 13, 2023 •
edited
Loading

closes: #33338

@quarkus-bot quarkus-bot bot added area/docstyle issues related for manual docstyle review area/documentation area/oidc labels Sep 13, 2023
@michalvavrik michalvavrik force-pushed the feature/oidc-map-scopes-to-identity-permissions branch from 81abb30 to 2bb4061 Compare September 13, 2023 22:26
@michalvavrik
Copy link
Member Author

Documentation CI looks like it failed over Caused by: java.nio.file.NoSuchFileException: ../target/asciidoc/generated/config/quarkus-log-logging-log-config.adoc which I can't see how it could be caused by this PR.

@quarkus-bot

This comment has been minimized.

Sign in to view
@michalvavrik
OIDC: map scope attribute to SecurityIdentity permissions

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: 399971774A2E75BA
Learn about vigilant mode
386e333
@michalvavrik michalvavrik force-pushed the feature/oidc-map-scopes-to-identity-permissions branch from 2bb4061 to 386e333 Compare September 14, 2023 10:18
sberyozkin
sberyozkin approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@sberyozkin sberyozkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @michalvavrik, the doc update showing two views of scopes is good.

I'll wait for a few hours in case Michelle has something to add, or we can tweak the docs later when Michelle has some time.

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 14, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@sberyozkin
Copy link
Member

I think we can merge this one - adding a minor doc update in this case is def not the cause of the build problem which other PRs are also failing with. Native security tests are passing

@sberyozkin sberyozkin merged commit 8677d59 into quarkusio:main Sep 15, 2023
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Sep 15, 2023
@quarkus-bot quarkus-bot bot added this to the 3.5 - main milestone Sep 15, 2023
@github-actions
Copy link

🙈 The PR is closed and the preview is expired.

@michalvavrik michalvavrik deleted the feature/oidc-map-scopes-to-identity-permissions branch September 15, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sberyozkin sberyozkin

Assignees
No one assigned
Labels
area/docstyle issues related for manual docstyle review area/documentation area/oidc kind/enhancement New feature or request release/noteworthy-feature
Projects
Quarkus Documentation
Status: Done
Milestone
3.5.0.CR1
Development

Successfully merging this pull request may close these issues.

Map OIDC scope claim to Permissions
2 participants
@michalvavrik @sberyozkin