-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exposed the serializable-model when generating client models. #907
Exposed the serializable-model when generating client models. #907
Conversation
My bad, I had set IntelliJ to optimize imports and reformat code, which changed everything the |
...in/java/io/quarkiverse/openapi/generator/deployment/codegen/OpenApiGeneratorCodeGenBase.java
Outdated
Show resolved
Hide resolved
client/integration-tests/serializable-model/src/main/resources/application.properties
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @denvitaharen.
Looks great in general. I just left a few minor comments.
...t/java/io/quarkiverse/openapi/generator/it/QuarkusSerializableModelRestEasyReactiveTest.java
Outdated
Show resolved
Hide resolved
.../java/io/quarkiverse/openapi/generator/deployment/wrapper/OpenApiClientGeneratorWrapper.java
Outdated
Show resolved
Hide resolved
.../java/io/quarkiverse/openapi/generator/deployment/wrapper/OpenApiClientGeneratorWrapper.java
Outdated
Show resolved
Hide resolved
Thanks for the comments @hbelmiro! I have updated the PR based on your feedback. Out of curiosity, why isn't star imports ok? I don't have any personal preferences, I just use what's default in my IDE and have never reflected or hade any problems with star imports :) |
@denvitaharen star imports don't bring any benefits, but some disadvantages:
|
Many thanks for submitting your Pull Request ❤️!
Issue: #869
Exposed the possibility to generate models that implement the
java.io.Serilizable
-interface. I changed the property from the proposedserializableModel
toserializable-model
since I thought it harmonized better with the naming of the other configurations.I wrote an new test module for this, maybe it was a bit over engineered, but I didn't find any existing suitable test to put this in, so I did a new module instead.
[0.9.x] Subject