Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the eslint configuration ended up requiring me to migrate everything at once, as well as the prettier configurations, so this PR should manage to close #44, #43, #42, #41, #40, #39, #38, #37, #36, #35, #34, #33, #32, #31, #30, and #3 (apologies for the massive spam).
A few notes on the changes:
.eslintrc
files (which use strings to point to plugins/configurations), and move to aeslint.config.js
file that imports the packages directly and passes the plugin objects back to eslint. It seems like a reasonable change, but some of the plugins currently in use have not yet added support for flat configs (see ESLint Flat Config Support typescript-eslint/typescript-eslint#7694). As a result, the new monorepo configuration does not use flat configs, but it should be a priority to switch over once the plugins we depend on have added support.sonarjs/no-duplicate-string
. I've worked on the assumption that this was because some eslint configs had simply not had the rule added, and put it in the monorepo root config. This can be overridden if necessary.When merging this PR, consider squashing first - there are several intermediary commits that I think would just pollute the history