Add CylinderSource class
#4890
Merged
Add CylinderSource class
#4890
+275
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Codecov Report
@@ Coverage Diff @@
## main #4890 +/- ##
=======================================
Coverage 95.98% 95.99%
=======================================
Files 131 131
Lines 21560 21607 +47
=======================================
+ Hits 20694 20741 +47
Misses 866 866 |
|
LGTM |
pyvista-bot
approved these changes
Sep 23, 2023
| """ | ||
| self.Update() | ||
| output = wrap(self.GetOutput()) | ||
| output.rotate_z(-90, inplace=True) |
There was a problem hiding this comment.
Sorry I wasn't able to review this timely. I have not tested this, but due to the rotation and translation in this method, could we get different result in these two cases for cyl_source = pv.CylinderSource(), cyl_source.output.plot() and pl.add_mesh(cyl_source). I think the latter will not have this rotation and translation?
There was a problem hiding this comment.
We are always happy to review, no matter when. Please review whenever you like.
And very good point. This is a bug and I have created #4956 .
This was referenced Sep 25, 2023
tkoyama010
added a commit
that referenced
this pull request
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
ConeSourceclass #4860 . AddCylinderSourceclass.translatefunction fromgeometric_objects.pytogeometric_sources.py.Details