Don't reimplement runtime_checkable
on py38+
#194
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-export it from
typing
instead.Prior to #184,
typing.runtime_checkable
didn't work ontyping_extensions.Protocol
. Now thattyping_extensions.Protocol
inherits fromtyping.Generic
on py38+, however, it does! This means that we can just re-exporttyping.runtime_checkable
on py38+, rather than reimplementing it on all versions <3.12.