pkg_resources: Updates from upstream typing merge
#11455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
…Avasam/typeshed into strict-setuptools.pkg_resources
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Add _EntryPoint alias
This comment has been minimized.
This comment has been minimized.
…-setuptools.pkg_resources
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Self-reviewing the amount of changes in 1 file, I'll put this back as draft and split it up in smaller chunks. |
This was referenced Feb 29, 2024
…-setuptools.pkg_resources
This comment has been minimized.
This comment has been minimized.
This was referenced Feb 29, 2024
Avasam
commented
Mar 4, 2024
Avasam
commented
Mar 4, 2024
This comment has been minimized.
This comment has been minimized.
…Avasam/typeshed into strict-setuptools.pkg_resources
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Avasam
changed the title
pkg_resources (setuptools): Make stubtest-complete and pyright-strictpkg_resources (setuptools): Make pyright-strict
…-setuptools.pkg_resources
Avasam
changed the title
pkg_resources (setuptools): Make pyright-strictpkg_resources (setuptools): Updates from upstream typing merge
This comment has been minimized.
This comment has been minimized.
This reverts commit a8cdbb2.
Avasam
changed the title
pkg_resources (setuptools): Updates from upstream typing mergepkg_resources: Updates from upstream typing merge
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Avasam
commented
Mar 8, 2024
Avasam
commented
Mar 8, 2024
| @@ -260,11 +259,11 @@ def get_provider(moduleOrReq: str) -> IResourceProvider: ... | |||
| def get_provider(moduleOrReq: Requirement) -> Distribution: ... | |||
|
|
|||
| class IMetadataProvider(Protocol): | |||
| def has_metadata(self, name: str) -> bool | None: ... | |||
| def has_metadata(self, name: str) -> bool: ... | |||
There was a problem hiding this comment.
Avasam
commented
Mar 8, 2024
| @@ -326,9 +325,9 @@ class NullProvider: | |||
| def get_resource_stream(self, manager: ResourceManager, resource_name) -> BytesIO: ... | |||
| def get_resource_string(self, manager: ResourceManager, resource_name): ... | |||
| def has_resource(self, resource_name) -> bool: ... | |||
| def has_metadata(self, name: str) -> bool | None: ... | |||
| def has_metadata(self, name: str) -> bool: ... | |||
There was a problem hiding this comment.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So why even complete
pkg_resourcesin the first place, if it's considered deprecated in favor ofimportlib.resources,importlib.metadataand their backports?Because I've started merging the stubs directly into the setuptools repo, with the goal of being able to take it out of typeshed. And in doing so, found a lot of improvements to the typeshed stubs. At that point I was a few changes away from completing it, so here it is.
This also allowed me to cross-validate a handful of annotations, and I'll use the typeshed stubs as the reference for an upcoming PR that finishes typing
pkg_resourcesupstream.