Speed up SCC dependency inference #18299
Merged
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid redundant computation of `frozenset(scc)`. This helps with incremental type checking of torch, since it has a big SCC. In my measurements this speeds up incremental checking of `-c "import torch"` by about 11%.
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
cdce8p
reviewed
Dec 16, 2024
| @@ -57,7 +57,11 @@ def prepare_sccs( | |||
| sccs: list[set[T]], edges: dict[T, list[T]] | |||
| ) -> dict[AbstractSet[T], set[AbstractSet[T]]]: | |||
| """Use original edges to organize SCCs in a graph by dependencies between them.""" | |||
| sccsmap = {v: frozenset(scc) for scc in sccs for v in scc} | |||
There was a problem hiding this comment.
If you wanted to keep the dict comprehension, you could use an assignment expression
sccsmap = {v: s for scc in sccs if (s := frozenset(scc)) is not None for v in scc} # type: ignore[redundant-expr]It adds an additional if not None check for each scc that's always true but necessary to use :=.
There was a problem hiding this comment.
Good point, but I think this version is clearer
hauntsaninja
approved these changes
Dec 16, 2024
To provide an additional data point. I'm seeing a ~10% improvement 🚀 on full runs (without cache) for Home Assistant. Just this PR and #18298. Before 3:21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid redundant computation of
frozenset(scc).This helps with incremental type checking of torch, since it has a big SCC. In my measurements this speeds up incremental checking of
-c "import torch"by about 11%.