Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release 1.1] Cherry-pick some mypyc build fixes #14820

Merged
merged 2 commits into from
Mar 2, 2023
Merged

[Release 1.1] Cherry-pick some mypyc build fixes #14820

merged 2 commits into from
Mar 2, 2023

Commits on Mar 2, 2023

  1. Support next types-setuptools update (python#14781) 

    A simple type-only change since mypyc explicitely uses setuptools'
monkeypatching. And `setup.py` imports from setuptools.

Tests should stay the same. This should fix a sudden failure of tests
once python/typeshed#9795 is merged.
    @Avasam @AlexWaygood
    Avasam authored and AlexWaygood committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    3180344 View commit details
    Browse the repository at this point in the history

  2. Unpin the types-setuptools build dependency (python#14787) 

    - The latest release of `types-setuptools` started causing type-check
errors (and, therefore, mypyc build errors) on the `master` branch: see,
e.g.
https://github.com/python/mypy/actions/runs/4275505309/jobs/7442902732.
- python#14781 addressed some of the new errors, but didn't quite fix the
build.
- python#14788 then pinned the `types-setuptools` dependency as a temporary
stopgap measure.
- This PR now attempts to unpin `types-setuptools` and fix the build
errors in a more principled way.
    @AlexWaygood
    AlexWaygood committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    441610e View commit details
    Browse the repository at this point in the history