Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mypybot/sync typeshed #14733

Merged
merged 4 commits into from
Feb 18, 2023
Merged

Mypybot/sync typeshed #14733

merged 4 commits into from
Feb 18, 2023

Commits on Feb 18, 2023

  1. Sync typeshed 

    Source commit:
python/typeshed@5ebf892
    @koogoro
    koogoro committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    7a3026d View commit details
    Browse the repository at this point in the history

  2. Remove use of LiteralString in builtins (python#13743)

    @hauntsaninja @koogoro
    hauntsaninja authored and koogoro committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    ba88ef8 View commit details
    Browse the repository at this point in the history

  3. Revert sum literal integer change (python#13961) 

    This is allegedly causing large performance problems, see 13821

typeshed/8231 had zero hits on mypy_primer, so it's not the worst thing
to undo. Patching this in typeshed also feels weird, since there's a
more general soundness issue. If a typevar has a bound or constraint, we
might not want to solve it to a Literal.

If we can confirm the performance regression or fix the unsoundness
within mypy, I might pursue upstreaming this in typeshed.

(Reminder: add this to the sync_typeshed script once merged)
    @hauntsaninja @koogoro
    hauntsaninja authored and koogoro committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    7b70c4f View commit details
    Browse the repository at this point in the history

  4. Revert typeshed ctypes change (python#14128) 

    Since the plugin provides superior type checking:
python#13987 (comment)
    @hauntsaninja @koogoro
    hauntsaninja authored and koogoro committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    a8019d5 View commit details
    Browse the repository at this point in the history