[dataclass_transform] support default parameters #14580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…s-transform-default-parameters
This comment has been minimized.
This comment has been minimized.
|
Could we add |
I noticed that Pyright had support for that, but I was holding off adding it here until I determined where it was made “official” (just for thoroughness’s sake). The CPython PR is pretty canonical so I’ll add support tomorrow :) |
|
Awesome! This pull request is huge for me. Really looking forward to it. |
This comment has been minimized.
This comment has been minimized.
JelleZijlstra
approved these changes
Feb 7, 2023
This comment has been minimized.
This comment has been minimized.
JukkaL
reviewed
Feb 7, 2023
This comment has been minimized.
This comment has been minimized.
|
Diff from mypy_primer, showing the effect of this PR on open source code: pydantic (https://github.com/samuelcolvin/pydantic)
+ pydantic/dataclasses.py:108: error: "field_specifiers" support is currently unimplemented [misc]
+ pydantic/dataclasses.py:124: error: "field_specifiers" support is currently unimplemented [misc]
+ pydantic/dataclasses.py:175: error: "field_specifiers" support is currently unimplemented [misc]
|
JukkaL
pushed a commit
that referenced
this pull request
Feb 14, 2023
Follow up on some of the recurring feedback from #14580 and #14657. There are many error messages similar to `X must be True or False.` in MyPy. This commit updates them all to: - remove the dangling period for consistency with other error messages - clarify that we need a `True` or `False` literal - use the `literal-required` error code for consistency with other literal errors This should have no impact outside of error message formatting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PEP 681 defines several parameters for
typing.dataclass_transform. This commit adds support for collecting these arguments and forwarding them to the dataclasses plugin. For this first iteration, only the*_defaultparameters are supported;field_specifierswill be implemented in a separate commit, since it is more complicated.