gh-118643: Fix AttributeError in the email module #119099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix regression introduced in pythongh-100884: AttributeError when re-fold a long address list. Also fix more cases of incorrect encoding of the address separator in the address list missed in pythongh-100884.
serhiy-storchaka
added
needs backport to 3.11
|
@pablogamboa, as an exception, I think that this should be backported to 3.11. It fixes a bug introduced in the last bugfix release of 3.11, and all |
|
Think that was for @pablogsal ! |
|
Sorry. 🤦♂️ I think it is not the first time of referring the wrong Pablo. 😉 |
|
Hello @serhiy-storchaka, I just tested this with the email that originally motivated me to open #118643 and the result is not correct. I will come back tomorrow with more details on exactly what is happening. |
|
Hello again, I think I was a bit sleepy when I tested this last night 😅 because I tested this again this morning and it worked as expected. Sorry for the noise and thank you for looking into this!
|
mgmacias95
reviewed
May 17, 2024
Co-authored-by: Marta Gómez Macías <mgmacias@google.com>
|
Thank you @mgmacias95 for testing this with real world examples. |
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 22, 2024
) Fix regression introduced in pythongh-100884: AttributeError when re-fold a long address list. Also fix more cases of incorrect encoding of the address separator in the address list missed in pythongh-100884. (cherry picked from commit 858b9e8) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 22, 2024
) Fix regression introduced in pythongh-100884: AttributeError when re-fold a long address list. Also fix more cases of incorrect encoding of the address separator in the address list missed in pythongh-100884. (cherry picked from commit 858b9e8) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-119389 is a backport of this pull request to the 3.13 branch. |
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
|
GH-119390 is a backport of this pull request to the 3.12 branch. |
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
May 22, 2024
…nGH-119099) Fix regression introduced in pythongh-100884: AttributeError when re-fold a long address list. Also fix more cases of incorrect encoding of the address separator in the address list missed in pythongh-100884. (cherry picked from commit 858b9e8) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-119393 is a backport of this pull request to the 3.11 branch. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix regression introduced in gh-100884: AttributeError when re-fold a long address list.
Also fix more cases of incorrect encoding of the address separator in the address list missed in gh-100884.