Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-112345: Let failed protocol subclasscheck show non-method members #112344

Merged
merged 11 commits into from
Nov 24, 2023
Merged

gh-112345: Let failed protocol subclasscheck show non-method members #112344

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
317d18a
Let failed protocol subclasscheck show non-method members
randolf-scholz Nov 23, 2023
100c309
📜🤖 Added by blurb_it.
blurb-it[bot] Nov 23, 2023
fd840b2
added test
randolf-scholz Nov 23, 2023
c70acc4
Update Lib/test/test_typing.py
randolf-scholz Nov 23, 2023
5db2670
use assertRaisesRegex
randolf-scholz Nov 23, 2023
71925d5
Update Lib/test/test_typing.py
randolf-scholz Nov 23, 2023
998b45e
sort members, fixed unit test
randolf-scholz Nov 23, 2023
77e3a4a
📜🤖 Added by blurb_it.
blurb-it[bot] Nov 23, 2023
f2e3276
removed duplicate blurp
randolf-scholz Nov 23, 2023
bc40f84
Update Lib/typing.py
randolf-scholz Nov 24, 2023
62b6f71
Update Lib/test/test_typing.py
randolf-scholz Nov 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion Lib/typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1828,8 +1828,13 @@ def __subclasscheck__(cls, other):
not cls.__callable_proto_members_only__
and cls.__dict__.get("__subclasshook__") is _proto_hook
):
non_method_attrs = {
AlexWaygood marked this conversation as resolved.
Show resolved Hide resolved
attr for attr in cls.__protocol_attrs__
if not callable(getattr(cls, attr, None))
}
raise TypeError(
"Protocols with non-method members don't support issubclass()"
"Protocols with non-method members don't support issubclass()."
f" Non-method members: {non_method_attrs}."
randolf-scholz marked this conversation as resolved.
Show resolved Hide resolved
)
if not getattr(cls, '_is_runtime_protocol', False):
raise TypeError(
Expand Down