Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-111874: Call __set_name__ on objects that define the method inside a typing.NamedTuple class dictionary as part of the creation of that class #111876

Merged
merged 17 commits into from Nov 27, 2023
Merged

gh-111874: Call __set_name__ on objects that define the method inside a typing.NamedTuple class dictionary as part of the creation of that class #111876

merged 17 commits into from Nov 27, 2023

Commits on Nov 9, 2023

  1. pythongh-111874: Call __set_name__ on objects that define the metho… 

    …d inside a `typing.NamedTuple` class dictionary as part of the creation of that class
    @AlexWaygood
    AlexWaygood committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    e3b703d View commit details
    Browse the repository at this point in the history

  2. fixup news

    @AlexWaygood
    AlexWaygood committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    f053310 View commit details
    Browse the repository at this point in the history

  3. Also add a test for TypedDict classes

    @AlexWaygood
    AlexWaygood committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    7ccff63 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'namedtuple-setname' of https://github.com/AlexWaygood/c… 

    …python into namedtuple-setname
    @AlexWaygood
    AlexWaygood committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    0d13e83 View commit details
    Browse the repository at this point in the history

  5. Revert "Also add a test for TypedDict classes" 

    This reverts commit 7ccff63.
    @AlexWaygood
    AlexWaygood committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    e4e968a View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2023

  1. Exception -> BaseException

    @AlexWaygood
    AlexWaygood committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    e0c88f0 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2023

  1. Address review (and fix bug)

    @AlexWaygood
    AlexWaygood committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    d8102fd View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2023

  1. Update Lib/test/test_typing.py 

    Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
    @AlexWaygood @JelleZijlstra
    AlexWaygood and JelleZijlstra committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    f2a57b2 View commit details
    Browse the repository at this point in the history

  2. Handle strange exceptions raised on attempting to access __set_name__

    @AlexWaygood
    AlexWaygood committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    1909fd5 View commit details
    Browse the repository at this point in the history

  3. typo

    @AlexWaygood
    AlexWaygood committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    ed53fcb View commit details
    Browse the repository at this point in the history

  4. big comment

    @AlexWaygood
    AlexWaygood committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    c2c65c6 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2023

  1. Revert "big comment" 

    This reverts commit c2c65c6.
    @AlexWaygood
    AlexWaygood committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    e79ea37 View commit details
    Browse the repository at this point in the history

  2. Revert "typo" 

    This reverts commit ed53fcb.
    @AlexWaygood
    AlexWaygood committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    9fd8b6b View commit details
    Browse the repository at this point in the history

  3. Revert "Handle strange exceptions raised on attempting to access `__s… 

    …et_name__`"

This reverts commit 1909fd5.
    @AlexWaygood
    AlexWaygood committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    fdab495 View commit details
    Browse the repository at this point in the history

  4. Add a test that asserts the correct behaviour

    @AlexWaygood
    AlexWaygood committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    3932d48 View commit details
    Browse the repository at this point in the history

  5. Address Serhiy's second review pass

    @AlexWaygood
    AlexWaygood committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    3359ff6 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into namedtuple-setname

    @AlexWaygood
    AlexWaygood committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    ef628da View commit details
    Browse the repository at this point in the history