gh-107576: Ensure __orig_bases__ are our own in get_original_bases
#107584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Gobot1234
commented
Aug 3, 2023
•
Gobot1234
commented
- Issue: Odd types.get_original_bases() behavior for classes with generic bases but no type arguments #107576
Co-authored-by: Chris Bouchard <chris@upliftinglemma.net>
Co-authored-by: AlexWaygood <alex.waygood@gmail.com>
JelleZijlstra
approved these changes
Aug 3, 2023
AlexWaygood
reviewed
Aug 3, 2023
Misc/NEWS.d/next/Library/2023-08-03-11-31-11.gh-issue-107576.pO_s9I.rst
Outdated
Show resolved
Hide resolved
…O_s9I.rst Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
|
Thanks @Gobot1234 for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
|
GH-107592 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 3, 2023
…_bases` (pythonGH-107584) (cherry picked from commit ed4a978) Co-authored-by: James Hilton-Balfe <gobot1234yt@gmail.com> Co-authored-by: Chris Bouchard <chris@upliftinglemma.net> Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Yhg1s
pushed a commit
that referenced
this pull request
Aug 3, 2023
…l_bases` (GH-107584) (#107592) gh-107576: Ensure `__orig_bases__` are our own in `get_original_bases` (GH-107584) (cherry picked from commit ed4a978) Co-authored-by: James Hilton-Balfe <gobot1234yt@gmail.com> Co-authored-by: Chris Bouchard <chris@upliftinglemma.net> Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Sep 18, 2023
Release 4.8.0 (September 17, 2023) No changes since 4.8.0rc1. Release 4.8.0rc1 (September 7, 2023) - Add `typing_extensions.Doc`, as proposed by PEP 727. Patch by Sebastián Ramírez. - Drop support for Python 3.7 (including PyPy-3.7). Patch by Alex Waygood. - Fix bug where `get_original_bases()` would return incorrect results when called on a concrete subclass of a generic class. Patch by Alex Waygood (backporting python/cpython#107584, by James Hilton-Balfe). - Fix bug where `ParamSpec(default=...)` would raise a `TypeError` on Python versions <3.11. Patch by James Hilton-Balfe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.