-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add validator ETH addresses (ERC20) #276
Conversation
@joe733 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@msamsami, please make this PR do one thing. Create another PR to move btc_adderess.py
to validators/crypto_addresses
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one more change.
# external | ||
import re | ||
|
||
from eth_hash.auto import keccak | ||
|
||
# local | ||
from validators.utils import validator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@msamsami, I meant the change to be as follows:
# standard
import re
# external
from eth_hash.auto import keccak
# local
from validators.utils import validator
As re
is from the standard library, eth_hash.auto.keccak
is an external dependency and validators.utils.validator
implies a local coupling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joe733 Sorry for the confusion. It's done. 802487f
Tests have failed. Ref: https://github.com/python-validators/validators/actions/runs/5387269990/jobs/9778426797?pr=276#step:6:182 Also, please use Instead if you simply run |
@joe733 I added backend dependencies of |
@msamsami thanks for the PR! |
This is a validator for ERC20 Ethereum (ETC) addresses.