fix: Etsy OAuth2 Authentication bugs #880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #880 +/- ##
=======================================
Coverage 77.77% 77.77%
=======================================
Files 347 347
Lines 10604 10606 +2
Branches 699 699
=======================================
+ Hits 8247 8249 +2
Misses 2200 2200
Partials 157 157
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mmd-osm
reviewed
Jan 30, 2024
social_core/backends/oauth.py
Outdated
| @@ -494,7 +494,7 @@ def get_code_verifier(self): | |||
|
|
|||
| def generate_code_challenge(self, code_verifier, challenge_method): | |||
| method = challenge_method.lower() | |||
| if method == "s256": | |||
| if method in ["s256", "S256"]: | |||
There was a problem hiding this comment.
„method“ should be lowercase here due to the previous line 496. Why would this change be needed?
There was a problem hiding this comment.
You're right. Removed this change.
|
Merged, thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Resolves Issue: #879
Types of changes
Please check the type of change your PR introduces:
Checklist
Other information
Note: This is a breaking change and could potentially break authentications.