Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugs: Etsy OAuth2 Authentication #879

Closed
amitray007 opened this issue Jan 30, 2024 · 0 comments · Fixed by #880
Closed

bugs: Etsy OAuth2 Authentication #879

amitray007 opened this issue Jan 30, 2024 · 0 comments · Fixed by #880

Comments

@amitray007
Copy link
Contributor

Expected behaviour

OAuth2 login should work normally.

Actual behaviour

  • Exception as username should be a string but Etsy returns integer user_id
  • PKCE Method from Etsy should S256 and not s256 as per BaseOAuth2PKCE
  • REDIRECT_STATE should not be added to redirect URI.

What are the steps to reproduce this issue?

Input clear steps to reproduce the issue for a maintainer.

  1. Just try logging in, It'll fail.
@amitray007 amitray007 mentioned this issue Jan 30, 2024
Merged
11 tasks
@nijel nijel linked a pull request Jan 31, 2024 that will close this issue
fix: Etsy OAuth2 Authentication bugs #880
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Etsy OAuth2 Authentication bugs amitray007/social-core
1 participant
@amitray007