chore: update dependencies

[radoering]

No description provided.

[dimbleby]

fyi I have jaraco/keyring#666 and jaraco/jaraco.classes#13 open trying to fix up the faulty types in those two projects. I wouldn't wait on them though: in poetry it only makes a difference to type annotations in unit test so certainly not worth holding up a release

Not sure about the changes in site_packages.py, if importlib-metadata doesn't promise to return a Path then I'd have thought the code was fine as it was?

(find_distribution_files_with_suffix() seems to be unused so that could be removed altogether, that's one less to worry about...)

[radoering]

Not sure about the changes in site_packages.py, if importlib-metadata doesn't promise to return a Path then I'd have thought the code was fine as it was?

importlib-metadata promises to return a SimplePath, which is a Protocol that just provides a subset of Path. According to mypy we cannnot create a Path from a SimplePath (that's probably true). Thus, the old code will only work if we get a real Path - or strictly speaking a PathLike or str. I assume it's fine to expect a real path since we are working with a venv. Or do you think it would be better to keep the old code and just add a #type: ignore?

[dimbleby]

Ah, different python versions - this returns Pathlike[str] according to typeshed.

I'd think the right thing to do is to raise a pull request at importlib-metadata, changing the return type to be a plain Path.

Presumably they are currently trying to avoid committing to a particular type, but hopefully should be open to agreeing that in fact returning their own odd half-Path is unhelpful for callers.

(Meanwhile if you are looking to cut a release... do whatever)

[dimbleby]

ugh, though python/importlib_metadata#480

in fact could be a zipfile.Path or other SimplePath

but I think this over-shot: it makes sense for the abstract Distribution to commit only to an abstract Path-ish, but a PathDistribution really should return a concrete Path. Maybe.

At the very least: SimplePath is not even exported by importlib-metadata so as things stand it really is hard for a type-conscious codebase to use this API.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.