Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing env keyword in Env._run #7626

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

novas0x2a
Copy link
Contributor

The env keyword contains the modified path (that uses get_temp_environ) so without it, anything using the input path here would get the wrong env.

fixes #7623

Pull Request Check List

Resolves: #7623

  • Added tests for changed code.
  • Updated documentation for changed code.

The env keyword contains the modified path (that uses get_temp_environ)
so without it, anything using the `input` path here would get the wrong
env.

fixes python-poetry#7623
@radoering radoering added impact/backport Requires backport to stable branch backport/1.4 labels Mar 17, 2023
@radoering radoering merged commit 4a27e8f into python-poetry:master Mar 17, 2023
poetry-bot bot pushed a commit that referenced this pull request Mar 17, 2023
The env keyword contains the modified path (that uses get_temp_environ)
so without it, anything using the `input` path here would get the wrong
env.

fixes python-poetry#7623

(cherry picked from commit 4a27e8f)
radoering pushed a commit that referenced this pull request Mar 17, 2023
The env keyword contains the modified path (that uses get_temp_environ)
so without it, anything using the `input` path here would get the wrong
env.

fixes python-poetry#7623

(cherry picked from commit 4a27e8f)
@novas0x2a novas0x2a deleted the run-env branch March 17, 2023 20:44
@AshwinNS
Copy link

I'm facing the same issue in poetry==1.4.2 also.

I have virtual env creation tuned off as i'm working inside container.

>> poetry install --sync
Package operations: 0 installs, 18 updates, 35 removals

  • Removing build (0.10.0)
  • Removing cachecontrol (0.12.11)
  • Removing cleo (2.0.1)
  • Removing crashtest (0.4.1)
  • Removing distlib (0.3.6)
  • Removing dulwich (0.21.5)
  • Removing html5lib (1.1)
  • Removing importlib-metadata (6.6.0)
  • Removing installer (0.7.0)
  • Removing jaraco-classes (3.2.3)
  • Removing jeepney (0.8.0)
  • Removing jsonschema (4.17.3)
  • Removing keyring (23.13.1)
  • Removing more-itertools (9.1.0)
  • Removing openai (0.27.4)
  • Removing pexpect (4.8.0)
  • Removing pkginfo (1.9.6)
  • Removing platformdirs (2.6.2)
  • Removing poetry (1.4.2)
  • Removing poetry-core (1.5.2)
  • Removing poetry-plugin-export (1.3.1)
  • Removing ptyprocess (0.7.0)
  • Removing pyproject-hooks (1.0.0)
  • Removing pyrsistent (0.19.3)
  • Removing rapidfuzz (2.15.1)
  • Removing requests-toolbelt (0.10.1)
  • Removing secretstorage (3.3.3)
  • Removing shellingham (1.5.0.post1)
  • Removing tomli (2.0.1)
  • Removing tomlkit (0.11.8)
  • Removing tqdm (4.65.0)
  • Removing trove-classifiers (2023.5.24)
  • Removing virtualenv (20.21.1)
  • Removing webencodings (0.5.1)
  • Removing zipp (3.15.0)
  • Updating pyasn1 (0.4.8 -> 0.5.0): Pending...
  • Updating typing-extensions (4.5.0 -> 4.6.2): Pending...

@TiansuYu
Copy link

TiansuYu commented Aug 8, 2023

Facing the same issue with python3.10 and poetry==1.5.1

Copy link

github-actions bot commented Mar 3, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
impact/backport Requires backport to stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

poetry install --sync attempts to remove itself when poetry is installed to a different venv
4 participants