Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify behavior of --extras and subcommands #7563

Merged
merged 2 commits into from Mar 4, 2023

Conversation

evanrittenhouse
Copy link
Contributor

@evanrittenhouse evanrittenhouse commented Feb 25, 2023

Pull Request Check List

Resolves: #7556

  • Added tests for changed code.
  • Updated documentation for changed code.

Documentation only

docs/pyproject.md Outdated Show resolved Hide resolved
Copy link
Contributor

@PabloEmidio PabloEmidio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appear to be all set

image

@evanrittenhouse
Copy link
Contributor Author

Re-requesting review since I had to rebase against master

@evanrittenhouse
Copy link
Contributor Author

Looks like it still needs a review from someone with write access - @finswimmer , possible to help out here?

@radoering radoering added area/docs Documentation issues/improvements impact/backport Requires backport to stable branch backport/1.4 labels Mar 4, 2023
@radoering radoering merged commit 6a0087b into python-poetry:master Mar 4, 2023
poetry-bot bot pushed a commit that referenced this pull request Mar 4, 2023
radoering pushed a commit that referenced this pull request Mar 4, 2023
Copy link

github-actions bot commented Mar 3, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/docs Documentation issues/improvements impact/backport Requires backport to stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using --all-extras does not install from project.optional-dependencies
3 participants