Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow writing IFDRational to UNDEFINED tag #7840

Merged
merged 2 commits into from Mar 11, 2024
Merged

Allow writing IFDRational to UNDEFINED tag #7840

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
904b8e5
Allow writing IFDRational to UNDEFINED tag
radarhere Feb 28, 2024
9637ea7
Merge branch 'main' into write_undefined
radarhere Feb 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 5 additions & 2 deletions Tests/test_file_tiff_metadata.py
View file
Open in desktop
Expand Up @@ -224,14 +224,17 @@ def test_writing_other_types_to_bytes(value: int | IFDRational, tmp_path: Path)
assert reloaded.tag_v2[700] == b"\x01"


def test_writing_other_types_to_undefined(tmp_path: Path) -> None:
@pytest.mark.parametrize("value", (1, IFDRational(1)))
def test_writing_other_types_to_undefined(
value: int | IFDRational, tmp_path: Path
) -> None:
im = hopper()
info = TiffImagePlugin.ImageFileDirectory_v2()

tag = TiffTags.TAGS_V2[33723]
assert tag.type == TiffTags.UNDEFINED

info[33723] = 1
info[33723] = value

out = str(tmp_path / "temp.tiff")
im.save(out, tiffinfo=info)
Expand Down
2 changes: 2 additions & 0 deletions src/PIL/TiffImagePlugin.py
View file
Open in desktop
Expand Up @@ -790,6 +790,8 @@ def load_undefined(self, data, legacy_api=True):

@_register_writer(7)
def write_undefined(self, value):
if isinstance(value, IFDRational):
value = int(value)
if isinstance(value, int):
value = str(value).encode("ascii", "replace")
return value
Expand Down