Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add keep_rgb option when saving JPEG to prevent conversion of RGB colorspace #7553

Merged
merged 6 commits into from Jan 1, 2024
Merged

Add keep_rgb option when saving JPEG to prevent conversion of RGB colorspace #7553

merged 6 commits into from Jan 1, 2024

Commits on Dec 14, 2023

  1. Add keep_rgb option to prevent RGB -> YCbCr conversion during JPEG write 

    libjpeg automatically converts RGB to YCbCr by default.  Add a keep_rgb
option to disable libjpeg's automatic conversion of RGB images during
write.
    @bgilbert
    bgilbert committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    4b422db View commit details
    Browse the repository at this point in the history

  2. Rearranged subsampling assertions

    @radarhere @bgilbert
    radarhere authored and bgilbert committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    f90827d View commit details
    Browse the repository at this point in the history

  3. Clarify JPEG tests for default/invalid subsampling 

    -1 is the default; 3 is invalid and should behave the same as the default.
    @bgilbert
    bgilbert committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    1414673 View commit details
    Browse the repository at this point in the history

Commits on Dec 26, 2023

  1. Fail if chroma subsampling selected when writing RGB JPEG 

    The user presumably doesn't intend to subsample the green and blue
channels.
    @bgilbert
    bgilbert committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    a5fab5f View commit details
    Browse the repository at this point in the history

  2. Add release note for JPEG keep_rgb option 

    Co-authored-by: Andrew Murray <radarhere@users.noreply.github.com>
    @bgilbert @radarhere
    bgilbert and radarhere committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    e2018a6 View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2023

  1. Check similarity of round-tripped YCbCr JPEG, for symmetry with RGB

    @bgilbert
    bgilbert committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    372083c View commit details
    Browse the repository at this point in the history