Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add keep_rgb option when saving JPEG to prevent conversion of RGB colorspace #7553

Merged
merged 6 commits into from Jan 1, 2024
Merged

Add keep_rgb option when saving JPEG to prevent conversion of RGB colorspace #7553

merged 6 commits into from Jan 1, 2024

Conversation

bgilbert
Copy link
Contributor

@bgilbert bgilbert commented Nov 14, 2023 •
edited

libjpeg automatically converts RGB to YCbCr by default. Add a keep_rgb option to disable libjpeg's automatic conversion of RGB images during write.

@radarhere radarhere added the JPEG label Nov 14, 2023
@radarhere radarhere changed the title Allow writing RGB JPEGs Added keep_colorspace option when saving JPEG to prevent conversion of RGB colorspace Nov 14, 2023
@bgilbert bgilbert marked this pull request as draft November 25, 2023 21:10
@bgilbert bgilbert changed the title Added keep_colorspace option when saving JPEG to prevent conversion of RGB colorspace Added keep_rgb option when saving JPEG to prevent conversion of RGB colorspace Nov 25, 2023
@bgilbert bgilbert changed the title Added keep_rgb option when saving JPEG to prevent conversion of RGB colorspace Add keep_rgb option when saving JPEG to prevent conversion of RGB colorspace Nov 25, 2023
@bgilbert bgilbert marked this pull request as ready for review November 25, 2023 21:34
@bgilbert
Copy link
Contributor Author

Rebased (first push) and switched to keep_rgb (second push).

@radarhere radarhere mentioned this pull request Nov 27, 2023
Merged
radarhere
radarhere previously approved these changes Nov 27, 2023
View reviewed changes
radarhere
radarhere reviewed Nov 27, 2023
View reviewed changes
Tests/test_file_jpeg.py Outdated Show resolved Hide resolved
@bgilbert
Copy link
Contributor Author

Added @radarhere's test improvements from bgilbert#3.

homm
homm reviewed Dec 4, 2023
View reviewed changes
Tests/test_file_jpeg.py Outdated Show resolved Hide resolved
homm
homm reviewed Dec 4, 2023
View reviewed changes
Tests/test_file_jpeg.py Outdated Show resolved Hide resolved
@radarhere radarhere dismissed their stale review December 4, 2023 12:54

Further discussion

@bgilbert bgilbert mentioned this pull request Dec 8, 2023
Merged
bgilbert and others added 3 commits December 13, 2023 18:26
@bgilbert
Add keep_rgb option to prevent RGB -> YCbCr conversion during JPEG write
4b422db 
libjpeg automatically converts RGB to YCbCr by default.  Add a keep_rgb
option to disable libjpeg's automatic conversion of RGB images during
write.
@radarhere @bgilbert
Rearranged subsampling assertions
f90827d
@bgilbert
Clarify JPEG tests for default/invalid subsampling
1414673 
-1 is the default; 3 is invalid and should behave the same as the default.
@bgilbert
Copy link
Contributor Author

Rebased onto current main and added release note.

@bgilbert
Copy link
Contributor Author

Is anything else needed here?

@bgilbert
Copy link
Contributor Author

Applied suggestions.

bgilbert and others added 2 commits December 26, 2023 12:37
@bgilbert
Fail if chroma subsampling selected when writing RGB JPEG
a5fab5f 
The user presumably doesn't intend to subsample the green and blue
channels.
@bgilbert @radarhere
Add release note for JPEG keep_rgb option
e2018a6 
Co-authored-by: Andrew Murray <radarhere@users.noreply.github.com>
nulano
nulano approved these changes Dec 27, 2023
View reviewed changes
Tests/test_file_jpeg.py Show resolved Hide resolved
@radarhere radarhere merged commit d93a5ad into python-pillow:main Jan 1, 2024
59 checks passed
@bgilbert bgilbert deleted the jpeg-rgb branch January 1, 2024 18:56
@radarhere radarhere mentioned this pull request Jan 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akx akx akx left review comments

@hugovk hugovk hugovk left review comments

@radarhere radarhere radarhere left review comments

@Yay295 Yay295 Yay295 left review comments

@homm homm homm approved these changes

@nulano nulano nulano approved these changes

Assignees
No one assigned
Labels
JPEG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@bgilbert @akx @homm @hugovk @radarhere @nulano @Yay295