Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve type annotation for babel.support.Translations.load #983

Merged
merged 2 commits into from Mar 2, 2023
Merged

Conversation

akx
Copy link
Member

@akx akx commented Mar 2, 2023

Fixes #982

@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Merging #983 (8553928) into master (0ce196f) will decrease coverage by 0.04%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master     #983      +/-   ##
==========================================
- Coverage   90.94%   90.90%   -0.04%     
==========================================
  Files          25       25              
  Lines        4352     4356       +4     
==========================================
+ Hits         3958     3960       +2     
- Misses        394      396       +2     
Impacted Files Coverage Δ
babel/support.py 84.76% <70.00%> (-0.56%) ⬇️
babel/messages/catalog.py 95.71% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@akx akx marked this pull request as ready for review March 2, 2023 14:03
babel/support.py Outdated Show resolved Hide resolved
akx and others added 2 commits March 2, 2023 16:08
Co-authored-by: Jonah Lawrence <jonah@freshidea.com>
@akx akx enabled auto-merge (squash) March 2, 2023 14:09
@akx akx merged commit 92e6fab into master Mar 2, 2023
@akx akx deleted the issue-982 branch December 12, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type annotation inconsistency
2 participants