Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise a deprecation warning when evolve receives insta as a kw arg #1117

Merged
merged 10 commits into from Apr 5, 2023
Merged

Raise a deprecation warning when evolve receives insta as a kw arg #1117

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
0e52d9a
Raise a deprecation warning when evolve receives insta as a kw arg
hynek Apr 3, 2023
898764e
Add news fragment
hynek Apr 3, 2023
880644e
Raise a better error
hynek Apr 4, 2023
09f526f
Handle too many pos args
hynek Apr 4, 2023
25b2336
Merge branch 'main' into deprecate-evolve-kw
hynek Apr 4, 2023
d031c6d
Lazy import
hynek Apr 4, 2023
516e6e9
Trim traceback
hynek Apr 4, 2023
e66fea7
Add test evolving a field named inst
hynek Apr 4, 2023
1a8a7aa
Spelling
hynek Apr 4, 2023
4b53373
Spin positively
hynek Apr 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions changelog.d/1117.change.md
View file
Open in desktop
@@ -1,3 +1,3 @@
Passing the instance to `attrs.evolve()` (and `attr.evolve()`) using a keyword argument is now deprecated and will be removed in, or after, April 2024.
It is now possible for `attrs.evolve()` (and `attr.evolve()`) to change fields named `inst` if the instance is passed as a positional argument.
hynek marked this conversation as resolved.
Show resolved Hide resolved

This makes it possible to change a field named `inst`.
Passing the instance using the `inst` keyword argument is now deprecated and will be removed in, or after, April 2024.