Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --log-file-mode option to the logging plugin, enabling appending to log-files #11979

Merged
merged 4 commits into from Feb 21, 2024

Conversation

Leithal3
Copy link
Contributor

Previously, the mode was hard-coded to be "w" which truncates the file before logging. Relevant documentation has been updated and tests have been added to validate the new functionality.

Closes #11978

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

Left two minor suggestions.

testing/logging/test_reporting.py Outdated Show resolved Hide resolved
testing/logging/test_reporting.py Outdated Show resolved Hide resolved
Leithal3 and others added 4 commits February 21, 2024 08:48
…to log-files

Previously, the mode was hard-coded to be "w" which truncates the file before logging.
Relevant documentation has been updated and tests have been added to validate the new functionality.
Co-authored-by: Bruno Oliveira <bruno@soliv.dev>
@nicoddemus nicoddemus enabled auto-merge (squash) February 21, 2024 11:49
@nicoddemus nicoddemus merged commit c5c729e into pytest-dev:main Feb 21, 2024
24 checks passed
@Leithal3 Leithal3 deleted the 11978-add-log-file-mode-option branch February 21, 2024 22:09
flying-sheep pushed a commit to flying-sheep/pytest that referenced this pull request Apr 9, 2024
…to log-files (pytest-dev#11979)

Previously, the mode was hard-coded to be "w" which truncates the file before logging.

Co-authored-by: Bruno Oliveira <bruno@soliv.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add log-file-mode option to enable appending instead of truncating
2 participants