Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.4.x] Fix user_properties not saved to XML if fixture errors during teardown #11382

Merged
merged 1 commit into from Sep 3, 2023
Merged

[7.4.x] Fix user_properties not saved to XML if fixture errors during teardown #11382

merged 1 commit into from Sep 3, 2023

Commits on Sep 3, 2023

  1. Fix user_properties not saved to XML if fixture errors during teardown 

    Move handling of user_properties to `finalize()`.

Previously if a fixture failed during teardown, `pytest_runtest_logreport` would not be called with "teardown", resulting in the user properties not being saved on the JUnit XML file.

Fixes: pytest-dev#11367
(cherry picked from commit 917ce9a)
    @fruch @nicoddemus
    fruch authored and nicoddemus committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    c0bfad6 View commit details
    Browse the repository at this point in the history