-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: closes #11343's [attr-defined] type errors #11345
Merged
nicoddemus
merged 9 commits into
pytest-dev:main
from
WarrenTheRabbit:add-type-ignore-for-attr-defined-errors
Aug 27, 2023
Merged
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
2a91c63
fix: closes #11343's [attr-defined] type errors
WarrenTheRabbit 7600243
Merge branch 'main' into add-type-ignore-for-attr-defined-errors
WarrenTheRabbit 15ebcf5
refactor: replace type:ignore with platform check
WarrenTheRabbit fe67feb
Merge branch 'add-type-ignore-for-attr-defined-errors' of https://git…
WarrenTheRabbit 2d5bfa8
refactor: add self-documenting UNRELIABLE keyword
WarrenTheRabbit f9aa628
refactor: self-document error flag with a constant
WarrenTheRabbit af4ebeb
doc: improve explanation of return values
WarrenTheRabbit 60f6566
refactor: change name of self-documenting constant
WarrenTheRabbit c7b602c
doc: remove unwanted implication
WarrenTheRabbit File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean this extra argument as some future-proofing?
I think this is the wrong approach: the caller should not need to know which is the value that represents an error from
os.getuid
. If it ever varies between platforms, it should be handled internally byget_user_id
itself.Now, if your intent is to improve reliability, instead of the hardcoded value we had before, you can move it to a constant:
(Also parameters should be camel case).