Consider testpaths for initial conftests #10988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoddemus
force-pushed
the
initial-testpaths-10987
branch
4 times, most recently
from
9b30c5f
to
2c38d8d
Compare
|
@nicoddemus does this also close #430 ? |
IIUC, yes because |
nicoddemus
commented
May 12, 2023
nicoddemus
force-pushed
the
initial-testpaths-10987
branch
2 times, most recently
from
129b365
to
49d99f0
Compare
The 'testpaths' option is meant to be identical to execute pytest passing the 'testpaths' directories explicitly. Fix pytest-dev#10987
`_set_initial_conftests` could break on some systems if a very long option was passed, because the `Path.exists()` call raises an `OSError` instead of returning `False`. Fix pytest-dev#10169
nicoddemus
force-pushed
the
initial-testpaths-10987
branch
from
19d3a6c
to
4cc05e7
Compare
|
Re-requesting review given I added a new commit also fixing #10169. |
RonnyPfannschmidt
approved these changes
May 12, 2023
nicoddemus
added a commit
to nicoddemus/pytest
that referenced
this pull request
May 12, 2023
…-10987 Consider testpaths for initial conftests (cherry picked from commit 76d1523)
nocarryr
added a commit
to nocarryr/python-dispatch
that referenced
this pull request
Jun 22, 2023
Issue related to `testpaths` option and nested conftest modules causes ImportErrors in the sphinx plugin tests. Needs further investigation, but just pin it for now Related changes: pytest-dev/pytest#10988
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
testpathsoption is meant to be identical to execute pytest passing the 'testpaths' directories explicitly.This also fixes #10169, given I had to change the same part of the code in order to get tests to pass on Python 3.7.
Fix #430
Fix #10169
Fix #10987