Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mitigate directory creation race condition #10607

Merged
merged 3 commits into from Jan 6, 2023
Merged

Commits on Dec 23, 2022

  1. Mitigate directory creation race condition

    Fixes pytest-dev#10604 which could intermittently display unexpected behavior between checking if the path exists and requesting creation. This was fairly prevalent when pytest was being invoked in parallel by another test runner (CTest) and trying to create the same parent-folder for multiple XMLs. A modest amount of testing did not reproduce other filesystem race conditions.
    
    This notably does not work around an edge case where the parent path of the XML could be created as a file instead of a folder or link. That vanishingly rare case should cause file creation to fail on the next line, with a fairly obvious exception message.
    Kadino committed Dec 23, 2022
    Configuration menu
    Copy the full SHA
    dc0fc9f View commit details
    Browse the repository at this point in the history

Commits on Dec 24, 2022

  1. Update junitxml.py

    Kadino committed Dec 24, 2022
    Configuration menu
    Copy the full SHA
    e5f87af View commit details
    Browse the repository at this point in the history
  2. Create 10607.bugfix.rst

    Kadino committed Dec 24, 2022
    Configuration menu
    Copy the full SHA
    a43f889 View commit details
    Browse the repository at this point in the history