Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Ran Benita <ran@unusedvar.com>
  • Loading branch information
RonnyPfannschmidt and bluetech committed Oct 2, 2021
1 parent c46e067 commit d2e9fd5
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions doc/en/deprecations.rst
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,11 @@ Below is a complete list of all pytest features which are considered deprecated.
configuring hook specs/impls using markers
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Before pluggy was a own package and had a clear api,
Before pluggy, pytest's plugin library, was its own package and had a clear API,
pytest just used ``pytest.mark`` to configure hooks.

The :py:func:`pytest.hookimpl` and :py:func:`pytest.hookspec` decorators
have been available since years and should be used.
have been available since years and should be used instead.

.. code-block:: python
Expand All @@ -44,7 +44,7 @@ have been available since years and should be used.
pytest_runtest_call.tryfirst = True
This now is declared as:
should be changed to:

.. code-block:: python
Expand Down
4 changes: 2 additions & 2 deletions src/_pytest/deprecated.py
Original file line number Diff line number Diff line change
Expand Up @@ -110,9 +110,9 @@
HOOK_LEGACY_MARKING = UnformattedWarning(
PytestDeprecationWarning,
"The hook{type} {fullname} uses old-style configuration options (marks or attributes).\n"
" please use the pytest.hook{type}({hook_opts}) decorator instead of pytest.mark \n"
"Please use the pytest.hook{type}({hook_opts}) decorator instead\n"
" to configure the hooks.\n"
" see https://docs.pytest.org/en/latest/deprecations.html"
" See https://docs.pytest.org/en/latest/deprecations.html"
"#configuring-hook-specs-impls-using-markers",
)

Expand Down

0 comments on commit d2e9fd5

Please sign in to comment.