Skip to content

Commit

Permalink
Merge pull request #12051 from jakkdl/test_debugging_pythonbreakpoint
Browse files Browse the repository at this point in the history
[minor/QoL] monkeypatch.delenv PYTHONBREAKPOINT in two tests that previously failed/skipped
  • Loading branch information
bluetech committed Mar 3, 2024
2 parents 82fe28d + 5e2ee71 commit 43492f5
Showing 1 changed file with 8 additions and 10 deletions.
18 changes: 8 additions & 10 deletions testing/test_debugging.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
# mypy: allow-untyped-defs
import os
import sys
from typing import List

Expand All @@ -10,9 +9,6 @@
import pytest


_ENVIRON_PYTHONBREAKPOINT = os.environ.get("PYTHONBREAKPOINT", "")


@pytest.fixture(autouse=True)
def pdb_env(request):
if "pytester" in request.fixturenames:
Expand Down Expand Up @@ -959,7 +955,10 @@ def test_nothing(): pass
result = pytester.runpytest_subprocess(*args)
result.stdout.fnmatch_lines(["*1 passed in *"])

def test_pdb_custom_cls(self, pytester: Pytester, custom_debugger_hook) -> None:
def test_pdb_custom_cls(
self, pytester: Pytester, custom_debugger_hook, monkeypatch: MonkeyPatch
) -> None:
monkeypatch.delenv("PYTHONBREAKPOINT", raising=False)
p1 = pytester.makepyfile(
"""
def test_nothing():
Expand Down Expand Up @@ -1003,11 +1002,10 @@ def test_nothing(): pass
result = pytester.runpytest_subprocess(*args)
result.stdout.fnmatch_lines(["*1 passed in *"])

@pytest.mark.skipif(
not _ENVIRON_PYTHONBREAKPOINT == "",
reason="Requires breakpoint() default value",
)
def test_sys_breakpoint_interception(self, pytester: Pytester) -> None:
def test_sys_breakpoint_interception(
self, pytester: Pytester, monkeypatch: MonkeyPatch
) -> None:
monkeypatch.delenv("PYTHONBREAKPOINT", raising=False)
p1 = pytester.makepyfile(
"""
def test_1():
Expand Down

0 comments on commit 43492f5

Please sign in to comment.