Fix compatibility with pytest 8.2 FixtureDef.unittest removal #800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`SubRequest` is a subclass of `FixtureRequest`, but is currently private so pytest-asyncio uses `Any` instead. However, `FixtureRequest` typing is sufficient for our needs, so can use that instead.
Since pytest 8.2 unittest and regular behave the same, so unittest special handling is no longer needed.
bluetech
force-pushed
the
pytest82-compat
branch
from
649bbe5
to
ee8bd5f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #800 +/- ##
==========================================
+ Coverage 95.01% 95.59% +0.58%
==========================================
Files 2 2
Lines 481 477 -4
Branches 97 96 -1
==========================================
- Hits 457 456 -1
+ Misses 15 12 -3
Partials 9 9 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
seifertm
approved these changes
Mar 19, 2024
There was a problem hiding this comment.
Thank you!
The pytest-asyncio CI only tests against the latest stable release of pytest, so I ran the tests against pytest-dev/pytest@532782a to verify it a second time. Works like a charm. Clean up commits are always welcome, too.
I added a changelog entry and I'll release a new version right away to avoid breakage when pytest 8.2 is released.
ffissore
added a commit
to ffissore/pytest-asyncio
that referenced
this pull request
Apr 29, 2024
This unblocks all users stuck with 0.21.1 due to pytest-dev#706
This was referenced Apr 29, 2024
seifertm
pushed a commit
that referenced
this pull request
Apr 29, 2024
This unblocks all users stuck with 0.21.1 due to #706
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since pytest 8.2 (still in development) unittest and regular will behave the same, so unittest special handling is no longer needed.
I also added two unrelated cleanup commits I noticed, if you prefer I can remove them.