Remove test dependencies: flaky, mypy #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
touilleWoman
requested review from
asvetlov,
seifertm and
Tinche
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #696 +/- ##
=======================================
Coverage 94.81% 94.81%
=======================================
Files 2 2
Lines 463 463
Branches 92 92
=======================================
Hits 439 439
Misses 16 16
Partials 8 8 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
|
Thanks for the PR! I mentioned the removed dependencies in the changelog, because they're relevant for downstream packagers. |
seifertm
changed the title
seifertm
approved these changes
Dec 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed flaky, mypy.
I removed also mypy-extensions, typing_extensions which are dependencies of mypy.
Although tomli is dependency of mypy, I didn't remove it because Pytest depends on tomli.
Resolves #674
Resolves #678