Introduce way to determine if a pytest Item is a pytest-asyncio test #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ubclass rather than the instance. Previously, PytestAsyncioFunction.substitute returned the Item instance unchanged, when no substitution occured. This change allows for different code branches based on whether the substitution happened or not. Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
…ted own_markers from being transferred to the subclass instance. Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
…test_collection_modifyitems to pytest_pycollect_makeitem. This change causes PytestAsyncioFunction items to exclusively replace those pytest.Function items that are eligible as async tests. That means, once a test item has been substituted, an isinstance check is sufficient to determine if the item is an async test. Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
…lementation of PytestAsyncioFunction subclasses. Added assertion for existing asyncio marker in PytestAsyncioFunction._from_function. Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
…est Item is an async test managed by pytest-asyncio. Signed-off-by: Michael Seifert <m.seifert@digitalernachschub.de>
seifertm
force-pushed
the
is_async_test
branch
from
69a1213
to
62ff26f
Compare
Merged
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #686 +/- ##
==========================================
+ Coverage 94.60% 94.81% +0.21%
==========================================
Files 2 2
Lines 463 463
Branches 95 92 -3
==========================================
+ Hits 438 439 +1
Misses 16 16
+ Partials 9 8 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the public function
is_async_test(pytest.Item) -> bool. The function is intended to be used in pytest hooks or by plugins to determine whether a test item is an async test managed by pytest-asyncio.The new function allows more convenient marking of all async tests in a test suite (see #676)