Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add CRS.to_2d() #1267

Merged
merged 8 commits into from Apr 11, 2023
Merged

ENH: Add CRS.to_2d() #1267

merged 8 commits into from Apr 11, 2023

Conversation

rhugonnet
Copy link
Contributor

@rhugonnet rhugonnet commented Apr 7, 2023

This PR adds CRS.to_2d(), with implementation mirroring that of CRS.to_3d(), tests, and one advanced example.

Nothing to change in the API as it will be generated by autoclass for CRS, I think?

@codecov
Copy link

codecov bot commented Apr 7, 2023

Codecov Report

Merging #1267 (895d518) into main (f376625) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1267   +/-   ##
=======================================
  Coverage   96.40%   96.41%           
=======================================
  Files          20       20           
  Lines        1810     1812    +2     
=======================================
+ Hits         1745     1747    +2     
  Misses         65       65           
Impacted Files Coverage Δ
pyproj/crs/crs.py 98.08% <100.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@snowman2 snowman2 added this to the 3.6.0 milestone Apr 7, 2023
pyproj/_crs.pxd Outdated Show resolved Hide resolved
Copy link
Member

@snowman2 snowman2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks 👍

@snowman2 snowman2 merged commit 0aba9d5 into pyproj4:main Apr 11, 2023
27 checks passed
@rhugonnet rhugonnet deleted the crs_to_2d branch April 11, 2023 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: Add CRS.to_2d()
2 participants