Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WHL: Add win32 to build_wheels matrix #1169

Merged
merged 1 commit into from
Nov 1, 2022
Merged

WHL: Add win32 to build_wheels matrix #1169

merged 1 commit into from
Nov 1, 2022

Conversation

molinav
Copy link
Contributor

@molinav molinav commented Oct 29, 2022

This PR extends the GitHub workflow build matrix to include one more item with variables {os: "windows-2019": arch: "auto32", triplet: "x86-windows"}, similarly to the already present win64 build.

  • Closes WHL: win32 wheels #1168
  • Tests added
    • No new tests, but I checked that the current tests pass on win32 (as run by cibuildwheel).
  • Fully documented, including history.rst for all changes and api/*.rst for new API
    • I have not updated history.rst because I was not sure if this addition was that relevant (wheels were already there in pyproj 3.3.1, so this PR simply brings them back).

@codecov
Copy link

codecov bot commented Oct 29, 2022

Codecov Report

Merging #1169 (4849cd1) into main (2a62e36) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1169   +/-   ##
=======================================
  Coverage   96.19%   96.19%           
=======================================
  Files          18       18           
  Lines        1707     1707           
=======================================
  Hits         1642     1642           
  Misses         65       65           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@snowman2
Copy link
Member

snowman2 commented Nov 1, 2022

Thanks @molinav 👍

@snowman2 snowman2 merged commit 7e5993b into pyproj4:main Nov 1, 2022
@snowman2 snowman2 added this to the 3.4.1 milestone Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WHL: win32 wheels
2 participants