Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update account-recovery.yml #3567

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update account-recovery.yml #3567

wants to merge 2 commits into from

Conversation

tarekziade
Copy link

@tarekziade tarekziade commented Jan 26, 2024

  1. changed the delay to reflect the current reality
  2. add a check box to tell the admin if the user has lost the recovery codes as well to avoid one extra round trip

For 2. here's an example of where this applies: #3200

Before the change:

  1. User: I lost my 2FA access
  2. Admin: I see valid recovery codes in the DB, have you tried them?
  3. User: I lost them as well or never downloaded them
  4. Admin: ok let me proceed with the reset process

After the change:

  1. User: I lost my 2FA access, and the recovery codes as well
  2. Admin: yes, I see valid recovery codes in the DB, ok let me proceed with the reset process

Why it matters? Because there can be months between two answers from the admin, so the change will spare those extra months.

- changed the delay to reflect the current reality
- add a check box to tell the admin if the user has lost the recovery codes as well to avoid one extra round trip
Co-authored-by: Paul Moore <p.f.moore@gmail.com>
@jeankobeis

This comment was marked as resolved.

@merwok

This comment was marked as resolved.

@jeankobeis

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants