Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: platform tag detection #560

Merged
merged 5 commits into from
Aug 21, 2023
Merged

fix: platform tag detection #560

merged 5 commits into from
Aug 21, 2023

Conversation

mayeut
Copy link
Member

@mayeut mayeut commented Aug 20, 2023

The first one fixes platform tag detection with GraalPy (xref pypa/packaging#710 / pypa/packaging#711)

@codecov
Copy link

codecov bot commented Aug 20, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +2.27% 🎉

Comparison is base (2bf5bb0) 70.07% compared to head (14764f3) 72.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #560      +/-   ##
==========================================
+ Coverage   70.07%   72.35%   +2.27%     
==========================================
  Files          13       13              
  Lines        1076     1085       +9     
==========================================
+ Hits          754      785      +31     
+ Misses        322      300      -22     
Files Changed Coverage Δ
src/wheel/bdist_wheel.py 55.77% <100.00%> (+8.83%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- use `struct.calcsize("P") == 4` rather than `sys.maxsize == 2147483647`
- extend the 32bit check to `linux-aarch64` => `linux-armv7l`
@agronholm
Copy link
Contributor

Could you add test coverage for the new lines not covered yet (the ones codecov pointed out)?

@mayeut
Copy link
Member Author

mayeut commented Aug 20, 2023

I'll try but it's not covered right now so it's not as easy as just extending existing test:
https://app.codecov.io/gh/pypa/wheel/blob/master/src%2Fwheel%2Fbdist_wheel.py#L263

@mayeut
Copy link
Member Author

mayeut commented Aug 20, 2023

Could you add test coverage for the new lines not covered yet (the ones codecov pointed out)?

Done

@agronholm
Copy link
Contributor

Thanks – one more thing: add a descriptive note (and attribution to yourself) to the changelog (docs/news.rst).

@agronholm agronholm merged commit 2008f0b into pypa:main Aug 21, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AssertionError: would build wheel with unsupported tag ('cp38', 'cp38', 'linux_aarch64')
2 participants