Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.12 support and no setuptools/wheel on 3.12+ #2558

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

chrysle
Copy link
Contributor

@chrysle chrysle commented Apr 25, 2023

Note this is my first little code contribution, so please be patient. Closes #2487

  • ran the linter to address style issues (tox -e fix)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
  • added news fragment in docs/changelog folder
  • updated/extended the documentation

@chrysle chrysle force-pushed the no-install-setuptools-wheel branch 2 times, most recently from bf4f053 to a119ed8 Compare April 25, 2023 15:19
src/virtualenv/seed/embed/base_embed.py Outdated Show resolved Hide resolved
src/virtualenv/seed/embed/base_embed.py Outdated Show resolved Hide resolved
src/virtualenv/seed/embed/base_embed.py Outdated Show resolved Hide resolved
@chrysle
Copy link
Contributor Author

chrysle commented Apr 26, 2023

Thanks for the review. Updated.

Copy link
Contributor

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need a test.

docs/user_guide.rst Outdated Show resolved Hide resolved
src/virtualenv/seed/embed/base_embed.py Outdated Show resolved Hide resolved
src/virtualenv/seed/embed/base_embed.py Outdated Show resolved Hide resolved
whitelist.txt Outdated Show resolved Hide resolved
@chrysle
Copy link
Contributor Author

chrysle commented Apr 26, 2023

Will look into this. Sorry for producing so much review work.

@chrysle chrysle force-pushed the no-install-setuptools-wheel branch from fc6a7d3 to a0390e7 Compare April 27, 2023 13:36
@gaborbernat gaborbernat force-pushed the no-install-setuptools-wheel branch 6 times, most recently from 678f07b to 343d855 Compare April 27, 2023 17:18
@gaborbernat
Copy link
Contributor

Ah this will get complicated, I'll take it from here 👍

@chrysle
Copy link
Contributor Author

chrysle commented Apr 27, 2023

Thank you! I'll try to be more help next time.

@gaborbernat gaborbernat force-pushed the no-install-setuptools-wheel branch 2 times, most recently from d4b72cc to 585ec87 Compare April 27, 2023 17:39
@gaborbernat gaborbernat changed the title Don't install setuptools and wheel on Python 3.12+ environments 3.12 support and no setuptools/wheel on 3.12+ Apr 27, 2023
@gaborbernat gaborbernat force-pushed the no-install-setuptools-wheel branch 11 times, most recently from b97cd7c to 8e24910 Compare April 27, 2023 22:16
@gaborbernat gaborbernat force-pushed the no-install-setuptools-wheel branch 2 times, most recently from eccb0bd to 54159a5 Compare April 27, 2023 22:21
@gaborbernat gaborbernat force-pushed the no-install-setuptools-wheel branch 2 times, most recently from 1507527 to b5a9506 Compare April 27, 2023 22:43
Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
@gaborbernat gaborbernat merged commit fd93dd7 into pypa:main Apr 27, 2023
39 checks passed
hroncok pushed a commit to fedora-python/virtualenv that referenced this pull request Apr 28, 2023
hroncok pushed a commit to fedora-python/virtualenv that referenced this pull request Apr 28, 2023
hroncok pushed a commit to fedora-python/virtualenv that referenced this pull request Apr 28, 2023
@chrysle chrysle deleted the no-install-setuptools-wheel branch April 28, 2023 17:28
SpecLad added a commit to SpecLad/pip that referenced this pull request May 15, 2023
…thon 3.12+

Due to the advent of build isolation, it is no longer necessary to install
setuptools and wheel in an environment just to install other packages.
Moreover, on Python 3.12 both ensurepip [1] and virtualenv [2] are to stop
installing setuptools & wheel by default. This means that when those packages
are present in a Python 3.12+ environment, it is reasonable to assume that
they are runtime dependencies of the user's project, and therefore should be
included in freeze output.

distribute is just obsolete.

[1] python/cpython#95299
[2] pypa/virtualenv#2558
SpecLad added a commit to SpecLad/pip that referenced this pull request May 15, 2023
…thon 3.12+

Due to the advent of build isolation, it is no longer necessary to install
setuptools and wheel in an environment just to install other packages.
Moreover, on Python 3.12 both ensurepip [1] and virtualenv [2] are to stop
installing setuptools & wheel by default. This means that when those packages
are present in a Python 3.12+ environment, it is reasonable to assume that
they are runtime dependencies of the user's project, and therefore should be
included in freeze output.

distribute is just obsolete.

[1] python/cpython#95299
[2] pypa/virtualenv#2558
SpecLad added a commit to SpecLad/pip that referenced this pull request May 15, 2023
…thon 3.12+

Due to the advent of build isolation, it is no longer necessary to install
setuptools and wheel in an environment just to install other packages.
Moreover, on Python 3.12 both ensurepip [1] and virtualenv [2] are to stop
installing setuptools & wheel by default. This means that when those packages
are present in a Python 3.12+ environment, it is reasonable to assume that
they are runtime dependencies of the user's project, and therefore should be
included in freeze output.

distribute is just obsolete.

[1] python/cpython#95299
[2] pypa/virtualenv#2558
SpecLad added a commit to SpecLad/pip that referenced this pull request May 28, 2023
…thon 3.12+

Due to the advent of build isolation, it is no longer necessary to install
setuptools and wheel in an environment just to install other packages.
Moreover, on Python 3.12 both ensurepip [1] and virtualenv [2] are to stop
installing setuptools & wheel by default. This means that when those packages
are present in a Python 3.12+ environment, it is reasonable to assume that
they are runtime dependencies of the user's project, and therefore should be
included in freeze output.

distribute is just obsolete.

[1] python/cpython#95299
[2] pypa/virtualenv#2558
tarpas pushed a commit to tarpas/virtualenv that referenced this pull request Jun 8, 2023
SpecLad added a commit to SpecLad/pip that referenced this pull request Jul 6, 2023
…thon 3.12+

Due to the advent of build isolation, it is no longer necessary to install
setuptools and wheel in an environment just to install other packages.
Moreover, on Python 3.12 both ensurepip [1] and virtualenv [2] are to stop
installing setuptools & wheel by default. This means that when those packages
are present in a Python 3.12+ environment, it is reasonable to assume that
they are runtime dependencies of the user's project, and therefore should be
included in freeze output.

distribute is just obsolete.

[1] python/cpython#95299
[2] pypa/virtualenv#2558
yselkowitz added a commit to yselkowitz/pytest-venv that referenced this pull request Jul 9, 2023
virtualenv 20.23.0 will no longer install setuptools and wheel by
default when run with Python 3.12:

pypa/virtualenv#2558

This causes the pkg_resources call in pytest-venv to fail, as that is
installed together with setuptools.  Use the virtualenv command line
argument to restore the previous behaviour.
fridex pushed a commit to fridex/pip that referenced this pull request Nov 8, 2023
…thon 3.12+

Due to the advent of build isolation, it is no longer necessary to install
setuptools and wheel in an environment just to install other packages.
Moreover, on Python 3.12 both ensurepip [1] and virtualenv [2] are to stop
installing setuptools & wheel by default. This means that when those packages
are present in a Python 3.12+ environment, it is reasonable to assume that
they are runtime dependencies of the user's project, and therefore should be
included in freeze output.

distribute is just obsolete.

[1] python/cpython#95299
[2] pypa/virtualenv#2558
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop installing setuptools and wheel by default on Python 3.12+ environments
2 participants