Return an empty list by default in pkg_resources.ResourceManager.cleanup_resources
#4244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Subclasses are expected to return a list. There's no mention of this method potentially returning `None` in the docstring.
|
Thank you very much @Avasam. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Subclasses of are expected to return a
list. There's no mention of this method potentially returningNonein the docstring. If this is intended, then the docstring should be updated, and the return type beOptional[list[str]]Work towards #2345 and merging
pkg_resourcesPull Request Checklist
newsfragments/.(See documentation for details)